Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
snap-group: Add test to verify drag to another desk and display in Overview
Bug: b/335463631
Test: Added new unit test
Change-Id: I45d9ef3d6dcb1699094b5a3878fa66f0d3916589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523982
Commit-Queue: Michele Fan <michelefan@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298435}
[Notif] Use enabling checks for Set Up List notif promo
Use feature enabling check instead of the feature flag check.
Bug: b/338254318
Change-Id: Ic306fa28c900b250db04fd2f93dd60fc74106538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523775
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298434}
Add support for version dir in app bound encryption path validation
Edge runs executables from within its own version directory, that we
would like to work with app bound encryption. This change adds support
for it, alongside tests.
Bug: 41493095
Change-Id: Iaaa07d9b4560c632ec8e4da4124732b3f3f98062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528077
Reviewed-by: S Ganesh <ganesh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Stefan Smolen <ssmole@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1298433}
Roll nearby-connections from bc44fee3747a to 112da1a7378e (1 revision)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/bc44fee3747a..112da1a7378e
2024-05-08 hais@google.com Remove extra semi which breaks ChromeOs build
> PiperOrigin-RevId: 631928582
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,kyleshima@google.com,nearby-chromeos-eng+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,kyleshima@google.com,nearby-chromeos-eng+autoroll@google.com
Change-Id: I2756c065dbaa2d4b1f54cbd546fd8bc7b4775786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528081
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298432}
webauthn: create enclave discovery outside of transport-based loop.
The enclave pretends to have "internal" transport, but it's not really a
platform authenticator. Since its discovery was created when "internal"
discoveries were created, it wasn't getting created on Windows when
webauthn.dll was present as that causes "internal" to be removed from
the list of active transports.
ef577965ace59598eb3e5960555301bf0175f053 tried to fix this, but having
the "internal" transport in Windows requests causes "This device" to
appear as a mechanism.
Bug: 339284461
Change-Id: I4f9505e69739de2d81f2dcf886644a2c4281e2f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523820
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298431}
[Extensions] Add header to mv2 deprecation panel
Add a header to the manifest v2 deprecation panel with icon, title,
subtitle and a dismiss button. Strings are pluralized based on number of
extensions that will be displayed.
Screenshot: https://drive.google.com/file/d/1iY0rKADE2mKpoI0tut1v_Z4un55w-F0t/view?usp=drive_link
Bug: 337191307
Change-Id: I246bfad3926d32da7294c1f4cbf61e976da4fd12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523455
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298430}
Reland "Updater: Allow self-uninstall if EULA is not accepted."
This is a reland of commit 15ed737dcb6cb9b15bd34a43381ffdfe622eebea
Original change's description:
> Updater: Allow self-uninstall if EULA is not accepted.
>
> This allows the updater to sense that all relevant apps have been
> uninstalled, and if so, to uninstall itself, without pinging the update
> server.
>
> Fixed: b/40195459
> Change-Id: Ie70933950dda77ce5245283fb9d863a934180d2a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522634
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1297738}
Change-Id: Ife33633330932362e1a4b2eda1d9f73fb13895e5
Cq-Include-Trybots: luci.chromium.try:win10-dbg
Fixed: b/40195459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5525779
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298429}
[Extensions] Add a webstorePrivate API to retrieve MV2 experiment status
Add a new API, webstorePrivate.getMV2ExperimentStatus(), that returns
the current status of the MV2 deprecation experiments. This allows the
webstore to appropriately update its UI inline with Chrome.
Add unittests for the same.
Bug: 337191307
Change-Id: I0aa07c72d21e24c26b842d6533e963b8d7a117d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526334
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Tim <tjudkins@chromium.org>
Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298428}
[Tab Group Sync] Update the bottom bar ungroup text for last tab ungroup
Update the tab grid dialog view's bottom bar ungroup text to display a
different string based on if the last tab is being ungrouped.
Bug: 324935931
Change-Id: I06db27c34d300af82ba802089418bb969d7fa45b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5525780
Commit-Queue: Brandon Fong <bjfong@google.com>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298427}
Roll ANGLE from 36cd4c1f076d to 602512a021f1 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/36cd4c1f076d..602512a021f1
2024-05-08 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 74fe79763664 to 44adb2021ffb (62 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Iec513847e6c16d76ae0c8c674ac54ef1d8fb2b56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526583
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298426}
Roll optimization-guide from 1831a0e08342 to 5e6bd02e69c3
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/1831a0e08342..5e6bd02e69c3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:339035914
Change-Id: I83c6d20264755b8da9b6399b7c30b985944add3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528214
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298425}
Remove iOS fallback path from MB.
MB contains a fallback path to load configs for builders from
//ios/build/bots, but there are no json files containing build configs
in //ios/build/bots.
Bug: 912681
Change-Id: Ica46add6ad9cc1da8632a6f6c0c4ef823c392c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4844540
Reviewed-by: Lindsay Pasricha <lindsayw@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298424}
Roll WebGPU CTS from 56a54ade32cc to a0f523c294fd (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/56a54ade32cc..a0f523c294fd
2024-05-08 16504129+sagudev@users.noreply.github.com unregisterAllServiceWorkers if serviceWorker are actually available (#3737)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC alanbaker@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel
Bug: None
Tbr: alanbaker@google.com
Change-Id: I5541b470060423eb065a5cf8049d5794a07680d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527782
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298423}
base/cpu: add AVX-512{F,BW}, AVX VNNI & AVX-512 VNNI detection
This is mostly for reporting purposes as it may influence optimization
development for AI related inference.
Test: Intel SDE 9.33 [-p4p, -future] on Tiger Lake
Change-Id: I743d7c53910f9f950e8602c7a45173bbb1765e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514202
Commit-Queue: James Zern <jzern@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Howard Yang <hcyang@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298422}
Revert "Add device_unittests filter dep to device/BUILD.gn"
This reverts commit 97aff9f9c932940b2ce74168722b1015ce5f7141.
Reason for revert: broke the build (crbug.com/339522822)
Original change's description:
> Add device_unittests filter dep to device/BUILD.gn
>
> BUG= b:339271455
>
> Change-Id: I17359831fbf0c07001e5f820ee12e41eda64f5a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528213
> Reviewed-by: Haiyang Pan <hypan@google.com>
> Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1298408}
Bug: b:339271455, 339522822
Change-Id: I38c3343186ef9823de005c597b398066d66c852a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528136
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298421}
[Read Aloud] Queue up distillations while speech is playing
This should prevent crashing or randomly stopping speech because of a
new distillation while speech is playing. With this, we will redistill
on pause if we need to, meaning speech would reset from the top again.
This is not ideal but still better than crashing.
Bug: 336178098,336411032,325103582,323415794
Fixed: 337015868
Change-Id: I503e7f44d7271ff4536b4481871870b99cf1eef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523783
Commit-Queue: Kristi Saney <kristislee@google.com>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1298420}
[a11y] Update caret blink rate when rate changes
When a user is using the touchscreen, they can slide the
caret blink rate setting slider while the caret is shown.
This changes makes the caret blink rate update immediately
in that case by checking the current blink rate against
the blink rate used last time blinking was started.
Bug: b/339258778
Test: Manual
Change-Id: I2fdb9adc923b2050f9ae3856ba43e6f60647c4fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526530
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298419}
Add histogram capturing whether CCT referrer is valid.
Bug: 323246479
Change-Id: I27ab3831ad0d8321ddf9b46a037f305fe35dc814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528018
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#1298418}
WebUI: Add a new Router class to replace iron-location
Add a Router singleton instance class to replace the following functions
of iron-location:
- Routing URL path, hash, and query changes to listeners. Note: Query
parameters are sent directly, since most clients used iron-location
with iron-query-params to translate between params structs and the
query string.
- Setting URL path, hash, and query from clients
Also updating the WebUI gallery demo to use the new Router.
Bug: 40943652
Change-Id: I890b497bd1fe2770eb325364081f9c4d4773dbf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523413
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298417}
[clank_v] Add failing tests to filter
Bug: 339327094
Change-Id: I3a6df7232c986493578999672e1802ab6ea44e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526007
Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#1298416}
Update histograms/README.md to mention kMaxValue in Mojo
Current document shows an enum class example for C++, but it's
slightly confusing as Mojo's enum is very similar but kMaxValue
is not needed for Mojo.
So, this patch adds an explicit example for Mojo and explains
why kMaxValue is not needed for Mojo enum.
Bug: n/a
Change-Id: I7b9b407c8521612073b15c1d2d199d7879c1d598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514334
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298415}
Update sysroot build_and_upload.py to update two DEPS files
Update the script to call gclient setdep twice for two DEPS files.
build/DEPS contains a copy of the sysroot deps in DEPS.
Downstream repos will recuresedeps into build/DEPS and retrieve these
sysroot deps.
Bug: b/328065301, b/336843415
Change-Id: I1f30909e19c7c9e93ddcbc0fc065e158b8dfacff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5519633
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/main@{#1298414}
Apply referrer as the CCT Client ID.
This change ensures that the application package name is correctly
routed to the SRP upon Omnibox Navigation on CCT.
Bug: 323246479
Change-Id: I1ce888412b7adf61f580ae42ab109d638e447493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527973
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298413}
Add a content internal browser test base class
Many content browser tests use a few common accessors and set up
methods, and many tests don't need more setup than that. Introduce a
new base class to minimize duplication of setup code and use it in
place of ContentBrowserTest. ContentSecurityPolicyBrowserTest is one
such example.
Test: Updating test code
Bug: 40202433
Change-Id: Id9dd6e78553588f2c2c0238b2e54b46eb812ac83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522337
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298412}
SidePanel: Migrate c/b/r/side_panel/customize_chrome to Lit, part 10.
In this part migrating app.ts, which is the last file that directly
depends on Polymer. Follow-up CLs will remove/replace any remaining
transitive dependencies to Polymer (like iron-pages), as well as
perform a few post-migration cleanups.
Also, had to remove `on-click="onChromeWebStoreLinkClick_"` from being
part of a localized string, as the equivalent Lit binding
`@click="${this.onChromeWebStoreLinkClick_}"` is not allowed in
$i18nRaw{} replacements and results in a failed CHECK(). Instead moved
the listener to the parent DOM element.
Bug: 40943652
Change-Id: Iae02335bf2c93e431adac7bf7226f082db5eadb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5521689
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298411}
Fix the incorrect casing issue of including DirectML.h
This change fixes the "Linux to Windows cross compile" build failure of
previous CL
https://chromium-review.googlesource.com/c/chromium/src/+/5514432
Bug: 338434855
Change-Id: Ic4db70e85b65996e2dd48fe0e99b92967eada3dc
Cq-Include-Trybots: luci.chromium.try:linux-win-cross-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527424
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298410}
media: Add flag for ARM HWDRM
We are delaying the launch of this but want to keep it enabled in the
ChromeOS builds while we finish up development. Since we don't have ARC
support enabled yet, disabling it at this point in MediaInterfaceProxy
will effectively disable its usage overall in the system. This will be
enabled by M128 and at that point we will remove this flag.
BUG=b:339304055,b:339207454
TEST=HWDRM is used w/ flag on and not w/ it off on geralt
Change-Id: Iafb358ada4a82b3b98152e2bff54a246f3757b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5525683
Reviewed-by: Justin Green <greenjustin@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/main@{#1298409}
Add device_unittests filter dep to device/BUILD.gn
BUG= b:339271455
Change-Id: I17359831fbf0c07001e5f820ee12e41eda64f5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528213
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298408}
Roll Depot Tools from 2f5dd07a00c9 to 1619815af451 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f5dd07a00c9..1619815af451
2024-05-08 ddoman@chromium.org [depot_tools] add file parameter support in git cl lint
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC chops-source-team@google.com,gavinmak@google.com,jojwang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:324595694
Tbr: gavinmak@google.com,jojwang@google.com
Change-Id: I840a07290883a1bfbb70563b20d987f5919fd5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526407
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298407}
[Jellybean] Expose cros-badge in cros-components
Bug: b/308855205
Change-Id: I3be912d2c48fa2ab388ebe29e3fb83f7f6b6ded4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526085
Reviewed-by: John Palmer <jopalmer@chromium.org>
Commit-Queue: Benjamin Zielinski <bzielinski@google.com>
Cr-Commit-Position: refs/heads/main@{#1298406}
Roll ios_internal from 2cf1a1b9f565 to 3cf92220a348
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/2cf1a1b9f565..3cf92220a348
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,gayane@google.com,gujen@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I157fb3332557e0bc24145ef29053092fe0c061ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527682
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298405}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1715198373-58ea3585210e5d6f28f783145ec54f28f8998681-fc8393217b1a1308d8c1c82d13a0e5a851fd30bc.profdata to chrome-mac-arm-main-1715205452-234e5d84c2dc9ab73ad726d4871dcbd185408dab-a454a882363374fe2f2f2cb7ccd13561c3937535.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia742351c2d41bd1a5834639fbd0044a367756197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528175
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298404}
customization: Remove mis-classified Xiaoxin Mouse
This PID/VID seems to be shared across a wide range of devices. One such
example is the ProtoArc KM100-A keyboard.
Fixed: b/338465449
Change-Id: Id891bafce813d0c3d89f173dda16ecb703e8bf83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528078
Reviewed-by: Danny Wang <wangdanny@google.com>
Commit-Queue: David Padlipsky <dpad@google.com>
Cr-Commit-Position: refs/heads/main@{#1298403}
[tab group v2] Add tab groups toggle on chrome://settings/appearance
This UI piece is gated by features::TabGroupsSaveUIUpdate
UI change:
https://screenshot.googleplex.com/7nt8EUNcAgLGKXc.png
Bug: 339256067
Change-Id: Ie3d39727b55992183d1efe1dd5669f558bcc8f4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5521681
Commit-Queue: pengchao Cai <pengchaocai@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298402}
Avoid slow redundant IsAccountManaged check during signin
During signin we re-check IsAccountManaged to ensure that callers have
correctly required the user to accept Account Management, but this call
is very slow (uncached currently) and not technically necessary.
Remove it for now until we add caching so we can unblock
EnterprisePolicyOnSignin rollout.
Bug: 339457762
Change-Id: I41bb9f0944075643ed302e1a3109976a7996978a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526318
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298401}
Roll SwiftShader from 76f7f8cfea80 to da334852e705 (5 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/76f7f8cfea80..da334852e705
2024-05-08 dsinclair@chromium.org Fixup CMake after spirv upgrade
2024-05-08 rjodin@chromium.org Update SPIR-V Tools to dd4b663e1
2024-05-08 rjodin@chromium.org Update SPIR-V Headers to 5e3ad389e
2024-05-08 rjodin@chromium.org spirv-tools: revert hand-made changes in spirv-tools to update with upstream
2024-05-08 rjodin@chromium.org update-spirv-tools.sh: add missing rms of Android.mk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC abdolrashidi@google.com,alanbaker@google.com,capn@chromium.org,swiftshader-eng+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: abdolrashidi@google.com,alanbaker@google.com,swiftshader-eng+autoroll@google.com
Change-Id: I1eef3bb97cf8e4a48ee1e59c9f007ab9b33c07ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526063
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298400}
[ASH] Update app filter visibility in response to selection/deletion
1. When selection is made, disable the app filter until selection mode
is exited. This prevents users from exiting the filtered state with
some entries selected.
2. Refresh apps list upon deletion, since the operation may require
updating the list if the deletion was for one of the app-specific
entries.
3. When there's no more apps to filter, hide the entire app filter
header, not just the app filter button.
demo: http://shortn/_a68P8Bkpu3
Bug: 338392168, 338348439, 338278747
Change-Id: I00fd717086cfc96ac5de013fd79a6a807e3b457a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514084
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298399}
Propagate the toolbar reset to the app
Bug: 308467782
Change-Id: Iefce210df8a92be97cb6298ba45d0cb76c913bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526000
Auto-Submit: Kristi Saney <kristislee@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1298398}
wm: Hide drag window in mini view
Test: manual
Change-Id: I467b79d9c21739bd6fd37c8feafaad8862087b22
Fixed: b:338466952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5524150
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298397}
Roll nearby-connections from 3b701c78f386 to bc44fee3747a (1 revision)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/3b701c78f386..bc44fee3747a
2024-05-08 hais@google.com use abs to make sure the id is not negative
> PiperOrigin-RevId: 631891168
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,kyleshima@google.com,nearby-chromeos-eng+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,kyleshima@google.com,nearby-chromeos-eng+autoroll@google.com
Change-Id: Ie33b8afeed11b4dd9ec7fb7ce4530d8c1d8f673f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527778
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298396}
[Tab Group Sync] Fix group size 1 creation
Tab groups of size 1 should use createSingleTabGroup,
mergeListOfTabsToGroup only works for > 1 tab because it filters any
tabs already in the tab group from having events emitted leading to the
state in the TabSwitcher and TabStrip being incorrect.
Longer term we should try to unify the pathways, but in the short term
this is easier and the calling convention of merging a tab to itself
feels wrong.
Fixed: 339508379
Change-Id: Ia3151adbf8fd07723bafb7ab2627163055f187b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5525778
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298395}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1715180400-4025bef89a87dc9247eb9a83c172970544c9442b-a95a72ef05ccdc53d02570321885910d25dde133.profdata to chrome-win32-main-1715191020-2acba4c77526ef91fd1980d93415c8cff82548a5-59273534785b02dede2e28f38cf86458f267bf87.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I3f2d3aa6f60cf42a4d2aa4884154f6874c26df2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526761
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298394}
Roll Catapult from 4a82c77f04b1 to cca9cecf31a2 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/4a82c77f04b1..cca9cecf31a2
2024-05-08 jeffyoon@google.com update chromeperf deployment for pinpoint
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC chrome-speed-operations@google.com,dberris@chromium.org,haowoo@google.com,jbudorick@chromium.org,johnchen@chromium.org,sullivan@chromium.org,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: haowoo@google.com
Change-Id: Ic4ac2ce4a67245a1657334fbc7c84ca9b1153278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527780
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298393}
Revert "[ASH] App attribution with a chip"
This reverts commit 53e76387f5fd3ba3774dd6cf0d409e4485d9e0f7.
Reason for revert: Fais internal builds
Original change's description:
> [ASH] App attribution with a chip
>
> This CL adds a chip that shows both an app icon + label for app
> attribution.
>
> Screenshot:
> - https://screenshot.googleplex.com/7wugZK8R9gWP6SS
> - https://screenshot.googleplex.com/9Dh88uWEe3XnaNe
>
> Bug: 331856225
> Change-Id: I342f4019b70f5372da033d87e19953f626317355
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514389
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Reviewed-by: Theresa Sullivan <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1298229}
Bug: 331856225, 339514033
Change-Id: I51d1071b5ac4ede67b0532999ee6f947917def9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527425
Owners-Override: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Tommy Nyquist <nyquist@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298392}
Add Greg Thompson as a11y reviewer
Not adding to Blink or services/accessibility for now.
Bug: none
Change-Id: I36ce10f03d97a135d177538cef8f95ee5bdb9e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526014
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298391}
[SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_OMNIBOX_COLOR parameter.
Clean up surface polish code related with SURFACE_POLISH_OMNIBOX_COLOR parameter.
Bug: 331667743
Change-Id: Ia47826b2c9ed8a9fcbad473e32eb7a4738115abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527239
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298390}
utr: Fetch and run the internal recipe for internal builders
There's now an internal recipe for the utr that should be used for
running internal builders. So this updates the utr script to
download the internal bundle and run the new recipe for chrome builders.
Since installing two different bundles in the same dir can have
conflicts, this moves the destination of the chromium bundle from
//tools/utr/.bundle/ to //tools/utr/.bundles/chromium/ and puts the
chrome bundle at //tools/utr/.bundles/chrome/.
Bug: 41492688
Change-Id: Ifca3165078470e4f8f23a3f65aab67201161f173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5510924
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298389}
Roll clank/internal/apps from fe8e1254957e to b436cd1e137d (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/fe8e1254957e..b436cd1e137d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,nyquist@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: nyquist@google.com
No-Try: true
Change-Id: I724d692a85cf29a9b66923290e5b37d739542e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527684
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1298388}
[bookmarks] Use colorOnPrimaryContainer for text/icon colors
Added 2 new semantic colors for text/icon colorOnPrimaryContainer
which are used for visual bookmark folders. Updated text style to use
the new text color and updated java code to use the new icon color.
Bug: 333732472
Change-Id: Ia276be5bc7224105183aa1311b95644ae71d79df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512622
Commit-Queue: Brandon Wylie <wylieb@google.com>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298387}
Remove redundancy in uploader.
`OnConfigFileResult` is called on seq task runner, and then again posts
`UpdateConfigFile` on the same runner. This is unnecessary.
Bug: None
Change-Id: Icadf7c7ba5cd16414874b95e083318fd30f1c8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526850
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Commit-Queue: Alberto Juarez <albertojuarez@google.com>
Reviewed-by: Alberto Juarez <albertojuarez@google.com>
Cr-Commit-Position: refs/heads/main@{#1298386}